workspacesView: Rename show to animateToOverview

WorkspacesDisplay is a ClutterActor subclass, and overriding
the show and hide methods require chaining up, otherwise the
actor isn't actually shown or hidden.

To avoid clashing with the pre-existing show method, rename
to animateToOverview.

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1295

diff --git a/js/ui/viewSelector.js b/js/ui/viewSelector.js
index 5c0dd9bb750fb0ebd215d54099560167f873cc2a..930e5b1e6db6d003451988d9e162c43d4f126510 100644 (file)
--- a/js/ui/viewSelector.js
+++ b/js/ui/viewSelector.js
@@ -273,7 +273,7 @@ var ViewSelector = GObject.registerClass({
 
     show() {
         this.reset();
-        this._workspacesDisplay.show(this._showAppsButton.checked);
+        this._workspacesDisplay.animateToOverview(this._showAppsButton.checked);
         this._activePage = null;
         if (this._showAppsButton.checked)
             this._showPage(this._appsPage);

diff --git a/js/ui/workspacesView.js b/js/ui/workspacesView.js
index 09155c5ae1576a475239810634540c6f606cf7f4..b196427cc932aba9d0326a15054e6d3a487de775 100644 (file)
--- a/js/ui/workspacesView.js
+++ b/js/ui/workspacesView.js
@@ -608,7 +608,7 @@ class WorkspacesDisplay extends St.Widget {
         return this._getPrimaryView().navigate_focus(from, direction, false);
     }
 
-    show(fadeOnPrimary) {
+    animateToOverview(fadeOnPrimary) {
         this._updateWorkspacesViews();
         for (let i = 0; i < this._workspacesViews.length; i++) {
             let animationType;